feat(ui5-message-strip): introduce custom colors #8757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenastoyanovaa
requested changes
Apr 15, 2024
packages/main/src/themes/sap_fiori_3/MessageStrip-parameters.css
Outdated
Show resolved
Hide resolved
packages/main/src/themes/sap_fiori_3_dark/MessageStrip-parameters.css
Outdated
Show resolved
Hide resolved
packages/main/src/themes/sap_horizon_dark/MessageStrip-parameters.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Regarding the commit message - maybe custom messages is not the best description. The customisation is actually only visual. Maybe something like
With the following enhancement, the end user will be able to message strips with custom colors, from a predefined set of colors.
elenastoyanovaa
requested changes
Apr 15, 2024
niyap
changed the title
Done |
simonarangelova
approved these changes
Apr 16, 2024
elenastoyanovaa
requested changes
Apr 16, 2024
elenastoyanovaa
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the following enhancement, the end user will be able to create message strips with custom colors from a predefined set of colors. That is achieved enhancing the
designproperty enumMessageStripDesignwith two new optionsColorSet1andColorSet2as well as the newly introduced propertycolorScheme.Setting the
designproperty value toColorSet1orColorSet2, then you are able to choose between 10 different colors for each usingcolorSchemeproperty with values from "1" to "10".