chore(Icons): make pathData async #8785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI5 Web Components Icons have a niche feature - exporting the SVG path string (
pathData
). This however causes issues asgetTheme()
must be called to determine which path version to export, andgetTheme()
is unreliable beforeboot()
is complete. Now, we instead export agetPathData
async function, that when awaited, will provide the saidpathData
.This is how an icon
accept.js
is generated now:Technical note:
onThemeRegistered
used to callgetTheme
before boot was complete (andOpenUI5Support
may change the outcome).BREAKING CHANGE: UI5 Web Components Icons now export
getPathData
(function) instead ofpathData
(string)If you used icons like this:
or like this:
there is no change and no adaptations are required.
In the rare case you imported
pathData
from icons, for example:you must change your code to, for example: