fix(ui5-link): remove unnecessary transparent border #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: - There was a transparent border displacing the link's text horizontally. It is mostly visible if there is an actual text component underneath. Solution: - The border is replaced by an outline with an offset. Now the ui5-link component doesn't have an invisible border and it is compliant with the visual specification. Fixes: SAP#8512
tsanislavgatev
approved these changes
Apr 25, 2024
ilhan007
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
There was a transparent border displacing the link's text horizontally. It is mostly visible if there is an actual text component underneath. Solution:
The border is replaced by an outline with an offset. Now the ui5-link component doesn't have an invisible border and it is compliant with the visual specification.
Fixes: #8512