refactor(ui5-wizard): rename event parameter #8845
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My suggestion for the commit message: "If the application code relied on |
Done :) |
simonarangelova
approved these changes
Apr 25, 2024
ilhan007
approved these changes
Apr 25, 2024
nnaydenow
pushed a commit
that referenced
this pull request
Apr 29, 2024
Rename `changeWithClick` to `withScroll` in the `WizardStepChangeEventDetail`. If the application code relied on `changeWithClic` event detail, it should now rely on `withScroll` event detail instead. The `withScroll` parameter will be set to true when the event is fired due to user scrolling. BREAKING CHANGE: `changeWithClick` was renamed to `withScroll` in the `WizardStepChangeEventDetail`. JIRA: BGSOFUIRILA-3867 Related to: #8461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
changeWithClicktowithScrollin theWizardStepChangeEventDetail.If the application code relied on
qchangeWithClicevent detail, it should now rely onwithScrollevent detail instead. ThewithScrollparameter will be set to true when the event is fired due to user scrolling.BREAKING CHANGE:
changeWithClickwas renamed towithScrollin theWizardStepChangeEventDetail.JIRA: BGSOFUIRILA-3867
Related to: #8461