Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'Number' and 'Email' #8897

Merged
merged 4 commits into from
May 9, 2024
Merged

fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'Number' and 'Email' #8897

merged 4 commits into from
May 9, 2024

Conversation

ndeshev
Copy link
Contributor

@ndeshev ndeshev commented May 2, 2024

fixes #8712

@ndeshev
fix(ui5-multi-input): prevent double value state message on nMore open (
7fb3348 
#8638)

* fix(ui5-multi-input): prevent double value state message on nMore open

fixes: #8586
@ndeshev
fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'N…
2ade382 
…umber' and 'Email' (#8866)

* fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'Number' and 'Email'

related to #8712
@ndeshev ndeshev changed the base branch from main to release-1.24 May 2, 2024 11:10
nnaydenow
nnaydenow previously requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix doesn't fully fix the issue. Please recheck the case where the cursor is at the beginning:

Screen.Recording.2024-05-07.at.12.27.55.mov

@ndeshev
Copy link
Contributor Author

ndeshev commented May 7, 2024

2.0 PR - #8866

@ndeshev
fix(ui5-multi-input): focus tokens on BACKSPACE for inputs of type 'N…
9f41f06 
…umber' and 'Email'

add note in the documentation
@ndeshev ndeshev dismissed nnaydenow’s stale review May 9, 2024 08:04

Not applicable

@ndeshev ndeshev merged commit 1461847 into release-1.24 May 9, 2024
9 checks passed
@ndeshev ndeshev deleted the mi-backspace branch May 9, 2024 08:05
@niyap niyap mentioned this pull request May 14, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikoletavnv nikoletavnv nikoletavnv approved these changes

@nnaydenow nnaydenow nnaydenow approved these changes

@elenastoyanovaa elenastoyanovaa Awaiting requested review from elenastoyanovaa

@ivoplashkov ivoplashkov Awaiting requested review from ivoplashkov

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SF][MultiInput]: Backspace does not work when the property set with type="Number" or "Email"
3 participants
@ndeshev @nikoletavnv @nnaydenow