Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-toolbar): prevent closing of overflow on interaction #8924

Merged
merged 3 commits into from
May 9, 2024
Merged

fix(ui5-toolbar): prevent closing of overflow on interaction #8924

merged 3 commits into from
May 9, 2024

Conversation

dobrinyonkov
Copy link
Contributor

Closes: #8913

@dobrinyonkov dobrinyonkov force-pushed the ui5-toolbar-prevent-overflow-closing branch from 5467a48 to 98b71e3 Compare May 9, 2024 09:09
PetyaMarkovaBogdanova
PetyaMarkovaBogdanova approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be nice if we add a test, describing the situation

vladitasev
vladitasev approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, the name of the variable can be changed a bit, f.e.

const eventType = e.type;
const eventTypeNonPrefixed: string = eventType.replace("ui5-", "");

but it's not that important

@dobrinyonkov dobrinyonkov merged commit 9fb21bf into main May 9, 2024
10 checks passed
@dobrinyonkov dobrinyonkov deleted the ui5-toolbar-prevent-overflow-closing branch May 9, 2024 13:44
dobrinyonkov added a commit that referenced this pull request May 10, 2024
@dobrinyonkov
fix(ui5-toolbar): prevent closing of overflow on interaction (#8924)
ab63c78 
* fix(ui5-toolbar): prevent closing of overflow on interaction

* chore: more descriptive variable names

* test: add test
@dobrinyonkov
Copy link
Contributor Author

downport: #8936

@dobrinyonkov dobrinyonkov mentioned this pull request May 10, 2024
Merged
dobrinyonkov added a commit that referenced this pull request May 10, 2024
@dobrinyonkov
fix(ui5-toolbar): prevent closing of overflow on interaction (#8936)
184175b 
* fix(ui5-toolbar): prevent closing of overflow on interaction (#8924)

* fix(ui5-toolbar): prevent closing of overflow on interaction

* chore: more descriptive variable names

* test: add test

* chore: adapt test to static area

* test: fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova PetyaMarkovaBogdanova approved these changes

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ToolbarSelect]: Overflow select cannot be expanded
3 participants
@dobrinyonkov @PetyaMarkovaBogdanova @vladitasev