Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-tabcontainer): adjust tabs to take 100% of TC height #895

Merged
merged 6 commits into from
Nov 27, 2019
Merged

fix(ui5-tabcontainer): adjust tabs to take 100% of TC height #895

merged 6 commits into from
Nov 27, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Oct 28, 2019

FIXES: #889

ilhan007
ilhan007 previously approved these changes Oct 28, 2019
View reviewed changes
fifoosid
fifoosid reviewed Oct 28, 2019
View reviewed changes
packages/main/src/Tab.hbs Outdated Show resolved Hide resolved
@ilhan007 ilhan007 dismissed their stale review October 28, 2019 15:39

other reviewer has a comment

pskelin
pskelin reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@pskelin pskelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test please?

pskelin
pskelin reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@pskelin pskelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When no height is set, the tabs should determine the height (like it is now). Check if your fix still supports this, or think if a property would be needed.

@MapTo0 MapTo0 closed this Oct 31, 2019
@MapTo0 MapTo0 reopened this Oct 31, 2019
vladitasev
vladitasev previously requested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A scrollbar appears on IE in the input sample now.

@fifoosid fifoosid merged commit 6fcf259 into master Nov 27, 2019
@fifoosid fifoosid deleted the tabs-full-height branch November 27, 2019 10:56
plamenivanov91 pushed a commit to plamenivanov91/ui5-webcomponents that referenced this pull request Nov 27, 2019
@MapTo0 @plamenivanov91
fix(ui5-tabcontainer): adjust tabs to take 100% of TC height (SAP#895)
e6c6e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin left review comments

@fifoosid fifoosid fifoosid left review comments

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev vladitasev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabContainer / Tab: It's not possible to use CSS height:100% inside a Tab
5 participants
@MapTo0 @pskelin @ilhan007 @vladitasev @fifoosid