Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-popup): remove popup from the tab chain #8955

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented May 14, 2024

Now the popup has tabindex=-1 and it is not a part of the page tab chain

Fixes #9094

@TeodorTaushanov TeodorTaushanov requested review from nnaydenow and a team May 14, 2024 10:21
Copy link
Contributor

@dimovpetar dimovpetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there any related incident to this? If yes - link it
  2. Add test

@TeodorTaushanov
Copy link
Member Author

  1. Is there any related incident to this? If yes - link it
  2. Add test

Done.

@TeodorTaushanov TeodorTaushanov merged commit aedcdb9 into main Jun 5, 2024
10 checks passed
@dimovpetar dimovpetar deleted the popup_focus_inside branch June 5, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-popover]: popover is part of the tab chain and get the focus
2 participants