Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-link): wrap text by default #9006

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented May 20, 2024

The text of ui5-link now wraps by default.

BREAKING CHANGE: wrapping-type property default value has changed from None to Normal.
Before:

<ui5-link>some very very very long link</ui5-link> <!-- would truncate the text if there is not enough space -->

Now:

<ui5-link>some very very very long link</ui5-link> <!-- would let the text wrap if there is not enough space -->

Related to #8461

Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.
Think we had to check the ui5-breadcrumbs component and fallback to truncation there.
Couldn't see any other component we need to check.

@hinzzx hinzzx marked this pull request as ready for review May 27, 2024 13:48
Copy link
Contributor

@tsanislavgatev tsanislavgatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving the change, but before merge, please wait for confirmation from the other teams. @SAP/ui5-webcomponents-topic-p @SAP/ui5-webcomponents-topic-rd

packages/main/src/Link.ts Outdated Show resolved Hide resolved
@hinzzx hinzzx merged commit 1924b54 into main Jun 3, 2024
10 checks passed
@hinzzx hinzzx deleted the link-default-wrapping branch June 3, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants