Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-list): refactored HighlightTypes #9061

Merged
merged 3 commits into from
May 27, 2024
Merged

refactor(ui5-list): refactored HighlightTypes #9061

merged 3 commits into from
May 27, 2024

Conversation

plamenivanov91
Copy link
Contributor

@plamenivanov91 plamenivanov91 commented May 27, 2024 •
edited
Loading

The HighlightTypes file and all its usages are now referred as Highlight.

BREAKING CHANGE: Highlight enum should be imported differently.
Before:

import HighlightTypes from "@ui5/webcomponents-base/dist/types/HighlightTypes.js";

Now:

import Highlight from "@ui5/webcomponents-base/dist/types/Highlight.js";

Related to: #8461

@plamenivanov91
refactor(ui5-list): refactored HighlightTypes
5588350 
The HighlightTypes file and all its usages are now referred as Highlight.
@plamenivanov91
Merge branch main into highlight-t
70cf200
@plamenivanov91
refactor(ui5-list): refactored HighlightTypes
1169287 
- removed wrongly generated files
@plamenivanov91 plamenivanov91 merged commit 2510224 into SAP:main May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobrinyonkov dobrinyonkov dobrinyonkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plamenivanov91 @dobrinyonkov