-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-ai-prompt-input): initial (experimental) implementation #9078
Conversation
The API looks reasonable +1 from my side
|
* @since 2.0.0-rc.1 | ||
* @public | ||
*/ | ||
@event("submit") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the reasoning behind having both submit
and change
. Submit is fired on click/enter, while change is fired on enter/focusout. What am i supposed to bind as an app developer? I would prefer to have only input/change events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed we have 2 use cases:
change
event to be used for validation (onfocusout)submit
event to be used for submitting the value to the backend
therefore I am leaving both events as implemented before
* The PromptInput is an AI component. | ||
* The `ui5-ai-prompt-input` component allows the user to write custom instructions in natural language, so that AI is guided to generate content tailored to user needs. | ||
* | ||
* **Note:** The web component is in an experimental state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add this note as an :::info label in the mdx file of the PromptInput to be consistent with the other components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are working on #9167 where @experimental
will be enabled to be used in class description and this note will be automatically generated
discussed in person that the current behaviour is OK
No description provided.