refactor(ui5-tag): wrap text by default #9126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text of `ui5-tag` now wraps by default. BREAKING CHANGE: `wrapping-type` property default value has changed from `None` to `Normal`. Before: ```html <ui5-tag>In Process</ui5-tag><!-- would truncate the text if there is not enough space --> ``` Now: ```html <ui5-tag>In Process</ui5-tag><!-- would let the text wrap if there is not enough space --> ``` Related to #8461
|
I approve the PR from UA perspective |
No matter if the tag is with wrapping-type="None" or wrapping-type="Normal" the height when there is only one line of text should be the same.
GerganaKremenska
requested changes
Jun 11, 2024
ilhan007
reviewed
Jun 11, 2024
GerganaKremenska
approved these changes
Jun 12, 2024
ilhan007
pushed a commit
that referenced
this pull request
Jun 14, 2024
* refactor(ui5-tag): wrap text by default The text of `ui5-tag` now wraps by default. BREAKING CHANGE: `wrapping-type` property default value has changed from `None` to `Normal`. Before: ```html <ui5-tag>In Process</ui5-tag><!-- would truncate the text if there is not enough space --> ``` Now: ```html <ui5-tag>In Process</ui5-tag><!-- would let the text wrap if there is not enough space --> ``` Related to #8461 * refactor(ui5-tag): fix test texsts * refactor(ui5-tag): fix height of the tags to be the same No matter if the tag is with wrapping-type="None" or wrapping-type="Normal" the height when there is only one line of text should be the same. * refactor(ui5-tag): merge adjustments and code review comments * refactor(ui5-tag): fix height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text of
ui5-tagnow wraps by default.BREAKING CHANGE:
wrapping-typeproperty default value has changed fromNonetoNormal. Before:Now:
Related to #8461