Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-segmented-button-item): add padding to icon when item is not in icon-only mode #9180

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

tsanislavgatev
Copy link
Contributor

fixes: #9172

Previous state:
image

State with the fix:
image

Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use padding-inline-end to be RTL friendly

@nnaydenow nnaydenow changed the title fix(ui5-segmentedbutton-item): add padding to icon when item is not in icon-only mode fix(ui5-segmented-button-item): add padding to icon when item is not in icon-only mode Jun 12, 2024
@tsanislavgatev tsanislavgatev merged commit a3fd241 into main Jun 12, 2024
10 checks passed
@tsanislavgatev tsanislavgatev deleted the segm-button-item-visual-fix branch June 12, 2024 14:19
ilhan007 pushed a commit that referenced this pull request Jun 14, 2024
kgogov pushed a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SegmentedButtonItem (2.0.0-rc.5)]: item is missing margin between icon and text
2 participants