fix(ui5-carousel): selected state is added to item #9184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerganaKremenska
requested review from
alexandar-mitsev,
LidiyaGeorgieva and
TeodorTaushanov
GerganaKremenska
force-pushed
the
carousel_aria_selected
branch
from
40cb4f3
to
23e9b60
Compare
GerganaKremenska
force-pushed
the
carousel_aria_selected
branch
from
23e9b60
to
648d3b0
Compare
GerganaKremenska
changed the title
TeodorTaushanov
approved these changes
Jun 13, 2024
GerganaKremenska
force-pushed
the
carousel_aria_selected
branch
from
3e6de96
to
5e333c7
Compare
ilhan007
pushed a commit
that referenced
this pull request
Jun 14, 2024
* fix(ui5-carousel): selected state is announced by screen readers * chore(ui5-carousel): give correct expected values to tests * fix(ui5-carousel): aria-hidden not needed
kgogov
pushed a commit
that referenced
this pull request
Jun 17, 2024
* fix(ui5-carousel): selected state is announced by screen readers * chore(ui5-carousel): give correct expected values to tests * fix(ui5-carousel): aria-hidden not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9027