Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-select): Remove unsupported method in IE #919

Merged
merged 2 commits into from
Nov 12, 2019
Merged

fix(ui5-select): Remove unsupported method in IE #919

merged 2 commits into from
Nov 12, 2019

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Nov 8, 2019

No description provided.

MapTo0
MapTo0 previously requested changes Nov 11, 2019
View reviewed changes
Copy link
Member

@MapTo0 MapTo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We better polyfill this instead of fixing.

vladitasev
vladitasev previously approved these changes Nov 11, 2019
View reviewed changes
@fifoosid fifoosid requested a review from MapTo0 November 11, 2019 13:18
@fifoosid fifoosid dismissed MapTo0’s stale review November 12, 2019 11:44

Changes are implemented

@fifoosid fifoosid merged commit f1bceea into master Nov 12, 2019
@fifoosid fifoosid deleted the select-ie branch November 12, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fifoosid @MapTo0 @vladitasev