fix(ui5-tabcontainer): fix overflow items appearance and selection #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ilhan007
commented
Nov 27, 2019
ilhan007
commented
- The icon is in the correct color for positive, negative and critical items.
- Pressing over the icon now works - it performs selection.
- The icon is in the correct color for positive, negative and critical items. - Pressing over the icon now works - it performs selection
ilhan007
changed the title
vladitasev
approved these changes
Nov 27, 2019
ilhan007
added a commit
that referenced
this pull request
Nov 27, 2019
This is a follow up of Follow up of: #988 where overflow items appearance in negative, positive and critical states have been fixed. However, I missed the default semantic appearance. Now the default semantic appearance of the overflow item text and icon in active state also looks correct.
ilhan007
added a commit
that referenced
this pull request
Dec 3, 2019
This is a follow up of Follow up of: #988 where overflow items appearance in negative, positive and critical states have been fixed. However, I missed the default semantic appearance. Now the default semantic appearance of the overflow item text and icon in active state also looks correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.