Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket.io downloads external package when installed #1030

Closed
marinho opened this issue Nov 10, 2016 · 4 comments
Closed

Socket.io downloads external package when installed #1030

marinho opened this issue Nov 10, 2016 · 4 comments

Comments

@marinho
Copy link

marinho commented Nov 10, 2016

Socket.io as a dependency requests [1] when installing, which is blocked by company's security policies.

Is there any solution in place for that? I'm going to fork sc5-styleguide and try to remove Socket.io dependency - not sure if that will be easy or not.

[1] https://github.com/rase-/node-XMLHttpRequest/archive/a6b6f2.tar.gz

@varya
Copy link
Contributor

varya commented Nov 10, 2016

Could you address this question to https://github.com/socketio/socket.io/issues ? They probably can suggest something.

@marinho
Copy link
Author

marinho commented Nov 11, 2016

Thank you for the response. This was the fix: [1], so, that means if you guys upgrade from socket.io~1.3.5 to ^1.4.0 it should fix the issue.

You can refer to [2], [3], [4] and [5] for more info.

I'm filing a PR, as I tried it and got it working, but it's literally just to bump to socket.io 1.4.0 or higher.

[1] socketio/engine.io-client#428
[2] https://github.com/socketio/socket.io/blob/master/History.md#140--2015-11-28
[3] https://github.com/socketio/socket.io-client/blob/master/History.md#140--2015-11-28
[4] https://github.com/socketio/engine.io-client/blob/master/History.md#160--2015-11-28
[5] socketio/socket.io-client@5bafc69

@varya
Copy link
Contributor

varya commented Nov 11, 2016

Thank you. Merged :-) And should be in the next release.

@marinho
Copy link
Author

marinho commented Nov 11, 2016

fantastic! I'll be waiting :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants