Jump while dragged up or down

[vovkaprigarin]

Short description

Up from .tip to .half and from .half to .tip position is incorrect while dragging.
This behavior was appeared on library version 1.4.0, previous version work perfectly.

Expected behavior

library version 1.3.5 and correct behavior:

Actual behavior

library version 1.4.0 and incorrect behavior:

Environment

Simulator iPhone 5s iOS 12.1

Library version
1.4.0

Installation method

• CocoaPods
• Carthage
• Git submodules

iOS version(s)
12.1

Xcode version
10.1

[scenee]

I will investigate the issue. Thanks for your report!

[scenee]

I tested this issue with the Samples app on v1.4.0, but unfortunately it isn't able to reproduce this issue. Could you please attach a sample code to reproduce this?

[scenee]

I could watch the issue once! But I’ve not be able to find a concrete repo way...

[vovkaprigarin]

@scenee I will create sample and post in this issue, but later, ok?

[scenee]

Of course, @vovkaprigarin! I appreciate your contribution 👍

[scenee]

@vovkaprigarin
I could fix this issue on fix-safeareainsets branch!
I found a safe area inset issue related to top/bottom dragging of a panel with a large title navigation bar. The branch resolves the issue. I'm not sure it's same, but it's possible this issue is also related to a safe area inset. So could you try the branch?

[pakko972]

Hi all, I had the exact same issue and branch fix-safeareainsets fixed it.

[scenee]

Thanks, all! I created PR #168. It will be released in v1.4.1 soon.

[vovkaprigarin]

@scenee fix-safeareainsets fixed this issue partially :) Now panel not jumping, but still moving to top. fix-top-dragging-boundary (for 167 issue) fixes it completely!

How check both fixes fix-top-dragging-boundary and fix-safeareainsets ?

[scenee]

I'm going to rebase fix-top-dragging-boundary soon by the master branch already merged fix-safeareainsets. I'll let you know it in this issue when I did. I'm pleased that you will check the new fix-top-dragging-boundary branch(both of fix-top-dragging-boundary and fix-safeareainsets)!

[scenee]

@vovkaprigarin
I prepared the new fix-top-dragging-boundary branch. I polish the previous one. I'm pleased that you check it.

[Lukaz32]

Should the problem be solved in the fix-top-dragging-boundary branch?
I still get the weird behaviour on it.
I've set my full position at -44, and also fpc.additionalSafeAreaInsets = UIEdgeInsets(top: -44, left: 0, bottom: 0, right: 0)
but after scrolling around it never returns to the correct position.

[scenee]

@Lukaz32
No, the branch intends to solve #167. But the problem should be fixed. This library hasn't taken care of a use case using it with fpc.additionalSafeAreaInsets. So could you please file a new issue and let me know source code of your modified Maps app?

[Lukaz32]

Oh, my bad, I thought it was related to this issue. Sure thing, I'll file a new issue on this matter. Thanks

[vovkaprigarin]

@scenee All is well. Works perfectly, Thank you!

[scenee]

@Lukaz32
Thanks! I will be sure to fix it.

@vovkaprigarin
Thank you, too! I could fix the fundamental issues by your contribution. I really appreciate it.