Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 3+ FloatingPanelController Subclassing #173

Closed
xysverma opened this issue Mar 26, 2019 · 3 comments
Closed

Swift 3+ FloatingPanelController Subclassing #173

xysverma opened this issue Mar 26, 2019 · 3 comments
Projects
v1.x

Comments

@xysverma
Copy link

I am trying to modify UI of FloatingPanelController to match my app requirement but since FloatingPanelController is not declared as open, i can't subclass it while using pod.

Is it possible to make it open and allow subclassing ?
@scenee scenee added this to To do in v1.x Mar 27, 2019
@scenee
Copy link
Owner

scenee commented Mar 29, 2019

Yes. it's possible! I created allow-subclassing branch. How about it?

@scenee scenee moved this from To do to In progress in v1.x Mar 29, 2019
@scenee scenee mentioned this issue Apr 11, 2019
Merged
v1.x automation moved this from In progress to Done Apr 11, 2019
@scenee
Copy link
Owner

scenee commented Apr 11, 2019

Now FloatingPanelController allows subclassing it 🐱

@xysverma
Copy link
Author

Awesome. Thanks :)

@rainypixels rainypixels mentioned this issue Apr 25, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
v1.x
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scenee @xysverma