Skip to content

Commit

Permalink
ENH: Generate Linux ARM wheels
Browse files Browse the repository at this point in the history
Features comes from the updated GitHub Action repository.

Ignore `error: definition of implicit copy constructor` warnings from
cleaver / googletest on macOS, e.g.:

```
Error
[58/76] Performing build step for 'googletest'
FAILED: externals/googletest/src/googletest-stamp/googletest-build externals/googletest/lib/lib/libgtest.a externals/googletest/lib/lib/libgtest_main.a externals/googletest/lib/lib/libgmock.a externals/googletest/lib/lib/libgmock_main.a /.../build/externals/googletest/src/googletest-stamp/googletest-build /.../build/externals/googletest/lib/lib/libgtest.a /.../build/externals/googletest/lib/lib/libgtest_main.a /.../build/externals/googletest/lib/lib/libgmock.a /.../build/externals/googletest/lib/lib/libgmock_main.a
cd /.../build/externals/googletest/lib && /Users/runner/work/_temp/-2070939391/cmake-3.24.2-macos-universal/CMake.app/Contents/bin/cmake --build . && /Users/runner/work/_temp/-2070939391/cmake-3.24.2-macos-universal/CMake.app/Contents/bin/cmake -E touch /.../build/externals/googletest/src/googletest-stamp/googletest-build
[1/8] Building CXX object googlemock/gtest/CMakeFiles/gtest_main.dir/src/gtest_main.cc.o
[2/8] Building CXX object googlemock/CMakeFiles/gmock_main.dir/src/gmock_main.cc.o
[3/8] Building CXX object googlemock/CMakeFiles/gmock.dir/src/gmock-all.cc.o
FAILED: googlemock/CMakeFiles/gmock.dir/src/gmock-all.cc.o
/Applications/Xcode_14.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++  -I/.../build/externals/googletest/src/googletest/googlemock/include -I/.../build/externals/googletest/src/googletest/googlemock -isystem /.../build/externals/googletest/src/googletest/googletest/include -isystem /.../build/externals/googletest/src/googletest/googletest -O3 -DNDEBUG -isysroot /Applications/Xcode_14.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -Wall -Wshadow -Werror -Wno-error=sign-conversion -DGTEST_HAS_PTHREAD=1 -fexceptions -W -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wredundant-decls -std=c++11 -MD -MT googlemock/CMakeFiles/gmock.dir/src/gmock-all.cc.o -MF googlemock/CMakeFiles/gmock.dir/src/gmock-all.cc.o.d -o googlemock/CMakeFiles/gmock.dir/src/gmock-all.cc.o -c /.../build/externals/googletest/src/googletest/googlemock/src/gmock-all.cc
In file included from externals/googletest/src/googletest/googlemock/src/gmock-all.cc:39:
In file included from externals/googletest/src/googletest/googlemock/include/gmock/gmock.h:59:
externals/googletest/src/googletest/googlemock/include/gmock/gmock-actions.h:457:3: error: definition of implicit copy constructor for 'PolymorphicAction<testing::internal::ReturnNullAction>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  GTEST_DISALLOW_ASSIGN_(PolymorphicAction);
```
  • Loading branch information
thewtex committed Jan 27, 2023
1 parent 9c58c0f commit fc650e6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-test-package.yml
Expand Up @@ -4,11 +4,11 @@ on: [push,pull_request]

jobs:
cxx-build-workflow:
uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@f8126440134ea50884f5ae97fda39ed6cab5f32f
uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@03626a23c22246e89e36c7e918a158c440f9b099
with:
warnings-to-ignore: "\"libcleaver.a.*has no symbols\" \"libitkcleaver.*has no symbols\""

python-build-workflow:
uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@f8126440134ea50884f5ae97fda39ed6cab5f32f
uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@03626a23c22246e89e36c7e918a158c440f9b099
secrets:
pypi_password: ${{ secrets.pypi_password }}
3 changes: 3 additions & 0 deletions CMakeLists.txt
Expand Up @@ -14,6 +14,9 @@ set(_itk_build_testing ${BUILD_TESTING})
if (CMAKE_CXX_COMPILER_IS_GNUCXX)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-maybe-uninitialized")
endif()
if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-copy")
endif()
set(_itk_build_shared ${BUILD_SHARED_LIBS})
set(BUILD_SHARED_LIBS OFF)
set(cleaver_GIT_REPOSITORY "https://github.com/SCIInstitute/Cleaver2")
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Expand Up @@ -12,7 +12,7 @@

setup(
name='itk-cleaver',
version='1.3.0',
version='1.3.1',
author='SCI Institute',
author_email='itk+community@discourse.itk.org',
packages=['itk'],
Expand Down

0 comments on commit fc650e6

Please sign in to comment.