Studio good/bad particle display #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cur_cos_appex is doubled as this quite often results in an average dot product well over 1.0 which can never be marked as a bad particle no matter whater the max angle.
iyerkrithika21
requested changes
Apr 4, 2022
There was a problem hiding this comment.
Works well for a single domain
But no particle color changes if the model has multiple domains; the associated job did run, though.
[2022-04-04 12:09:10.420|ShapeWorksStudioApp.cpp|614] MESSAGE: Project loaded: ellipsoid_multiple_domain_tiny_test_singlescale.xlsx
[2022-04-04 12:09:18.958|ParticleNormalEvaluationJob.cpp|47] MESSAGE: ParticleNormalEvaluationJob: found 97/128 good particles
[2022-04-04 12:09:23.210|ParticleNormalEvaluationJob.cpp|47] MESSAGE: ParticleNormalEvaluationJob: found 97/128 good particles
[2022-04-04 12:10:02.368|ParticleNormalEvaluationJob.cpp|47] MESSAGE: ParticleNormalEvaluationJob: found 11/128 good particles
|
@iyerkrithika21 , great catch. I had all the machinery in place for multiple domains, but there were a couple of issues with it. Should work now.
|
iyerkrithika21
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: