Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python Image copy-from-numpy constructor #965

Closed
cchriste opened this issue Feb 12, 2021 · 3 comments
Closed

Fix Python Image copy-from-numpy constructor #965

cchriste opened this issue Feb 12, 2021 · 3 comments
Assignees
@cchriste
Milestone
6.1 Release (June...

Comments

@cchriste
Copy link
Contributor

Our current attempt to copy a numpy array into an image is broken.
.def(py::init([](py::array_t<long> np_array) {

This relates to #903 and #716
@cchriste cchriste self-assigned this Feb 12, 2021
@cchriste cchriste mentioned this issue Feb 12, 2021
Closed
@sheryjoe sheryjoe modified the milestones: 6.0 Leftover, 6.1 Release (May 2021) Feb 15, 2021
This was referenced Mar 11, 2021
Closed
Merged
@cchriste cchriste mentioned this issue May 13, 2021
Closed
@cchriste cchriste added the QA label May 19, 2021
@cchriste
Copy link
Contributor Author

This is now working from the pybind pull request

This was referenced May 19, 2021
Closed
Closed
@sheryjoe
Copy link
Contributor

@cchriste should we close this?

@cchriste
Copy link
Contributor Author

cchriste commented Jun 4, 2021

pybind merged with added tests, closing issue

@cchriste cchriste closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cchriste cchriste

Labels
None yet
Projects
None yet
Milestone
6.1 Release (June 2021)
Development

No branches or pull requests
2 participants
@cchriste @sheryjoe