Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements getsolvetime #18

Merged
merged 3 commits into from
Sep 15, 2016
Merged

implements getsolvetime #18

merged 3 commits into from
Sep 15, 2016

Conversation

fserra
Copy link
Collaborator

@fserra fserra commented Sep 14, 2016

fix #17

@mlubin
Copy link
Collaborator

mlubin commented Sep 14, 2016

👍
If you've tested it locally let's merge after travis passes.

@fserra
Copy link
Collaborator Author

fserra commented Sep 14, 2016

If this is a valid test:

m = Model(solver=SCIPSolver())
@variable(m, x)
solve(m)
getsolvetime(m)

Then it is good to merge

@mlubin
Copy link
Collaborator

mlubin commented Sep 14, 2016

Yes, it's a valid test (wouldn't hurt to add something to the unit tests).

@fserra
Copy link
Collaborator Author

fserra commented Sep 14, 2016

how do you call getsolvetime from mathprogbase??

@mlubin
Copy link
Collaborator

mlubin commented Sep 14, 2016

MathProgBase.getsolvetime

@fserra
Copy link
Collaborator Author

fserra commented Sep 14, 2016

Ok, this is a mess.

@leethargo we are freeing the transformed problem after the SCIPsolve in CSIPsolve and so the time obtained by SCIPgetSolvingTime is 0.

We have to do something about this, like a function that needs to be called before modifying a problem.
Otherwise, we would need to store also the solving time data in CSIP 😧

How would such a function be integrated? Would we need to call it basically in every method with a ! in its name?

@rschwarz
Copy link
Collaborator

Was problem modification the only issue with the missing freeTransform after the solve?

@fserra
Copy link
Collaborator Author

fserra commented Sep 14, 2016

I think yes

On Sep 14, 2016 15:09, "Robert Schwarz" notifications@github.com wrote:

Was problem modification the only issue with the missing freeTransform
after the solve?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#18 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFNG9rA2GcawinYURrF9XUgw6ANCcWnsks5qp_IbgaJpZM4J8oHC
.

@rschwarz
Copy link
Collaborator

I don't like it, but as with PySCIPOpt, it may be unavoidable if we don't want to restrict the feature set.

@rschwarz
Copy link
Collaborator

@fserra : can you add your tests?

@fserra
Copy link
Collaborator Author

fserra commented Sep 15, 2016

done

@rschwarz rschwarz merged commit 5c0c80c into master Sep 15, 2016
@rschwarz rschwarz deleted the fs/getsolvetime branch July 4, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement getsolvetime
3 participants