-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with implicit and duplicate constraints for variable bounds #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bounds could be relaxed and should be reset to (-)SCIPinfinity then
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=========================================
+ Coverage 6.42% 7.06% +0.63%
=========================================
Files 121 121
Lines 3719 3738 +19
=========================================
+ Hits 239 264 +25
+ Misses 3480 3474 -6
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 332
💛 - Coveralls |
Could still add some tests (and handling) of changes in the constraint set for var bounds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #79
Still needs additional tests. Maybe prints too many warnings now. Probably is too conservative (does not consider variable type when throwing error about existing bounds).
In particular, will still fail for these cases now: