Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with implicit and duplicate constraints for variable bounds #81

Merged
merged 10 commits into from
Jan 8, 2019

Conversation

rschwarz
Copy link
Collaborator

@rschwarz rschwarz commented Jan 6, 2019

fixes #79

Still needs additional tests. Maybe prints too many warnings now. Probably is too conservative (does not consider variable type when throwing error about existing bounds).

In particular, will still fail for these cases now:

  • fixing a binary variable
  • having two separate constraints, one for the lower bound, one for the upper bound

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #81 into master will increase coverage by 0.63%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #81      +/-   ##
=========================================
+ Coverage    6.42%   7.06%   +0.63%     
=========================================
  Files         121     121              
  Lines        3719    3738      +19     
=========================================
+ Hits          239     264      +25     
+ Misses       3480    3474       -6
Impacted Files Coverage Δ
src/MOI_wrapper.jl 71.72% <93.54%> (+4.86%) ⬆️
src/wrapper/pub_var.jl 2.4% <0%> (+1.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06c0f5...6ad4371. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 6, 2019

Pull Request Test Coverage Report for Build 332

  • 14 of 16 (87.5%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.04%) to 6.677%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/MOI_wrapper.jl 14 16 87.5%
Files with Coverage Reduction New Missed Lines %
src/MOI_wrapper.jl 1 67.58%
Totals Coverage Status
Change from base Build 329: 2.04%
Covered Lines: 249
Relevant Lines: 3729

💛 - Coveralls

@rschwarz
Copy link
Collaborator Author

rschwarz commented Jan 7, 2019

Could still add some tests (and handling) of changes in the constraint set for var bounds.

@rschwarz rschwarz merged commit 2ec882d into master Jan 8, 2019
@rschwarz rschwarz deleted the rs/dupl_bounds branch January 8, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary variables with bounds
2 participants