Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkgdown update #239

Closed
SCasanova opened this issue Mar 11, 2024 · 6 comments · Fixed by #240
Closed

Pkgdown update #239

SCasanova opened this issue Mar 11, 2024 · 6 comments · Fixed by #240

Comments

@SCasanova
Copy link
Owner

Is the action to update pkgdown working? I'm not sure how it works but it seems it's still on 1.3. Could you direct me to the right place @pbulsink

@pbulsink
Copy link
Collaborator

Good Catch. I looked and saw the warning at the bottom of the run here: https://github.com/SCasanova/f1dataR/actions/runs/8226091186. I can find a new pkgdown action and swap it in.

@SCasanova
Copy link
Owner Author

Thanks!

@pbulsink
Copy link
Collaborator

@SCasanova - so pkgdown builds correctly now, but I think the github pages build job pulls from the wrong branch...

This is unfortunately something that's set in your personal gh settings, so you may be able to sort it out with a bit of digging. I saw this that might help https://stackoverflow.com/a/76960283/3933405. Try set the Github Pages setting to build from the gh-pages branch?

Alternatively, we can modify the pkgdown build job to push to master but that's a bit messier.

@SCasanova
Copy link
Owner Author

Hmmm I see. I will dig. Thanks

@SCasanova SCasanova reopened this Mar 12, 2024
@pbulsink
Copy link
Collaborator

I found this when looking for a different repo. https://fanwangecon.github.io/PkgTestR/articles/ffv_pkgdown_github.html You might have some success with rerunning the following two functions and allowing it to overwrite the .yml files:

usethis::use_github_action("pkgdown")

usethis::use_pkgdown_github_pages()

@SCasanova
Copy link
Owner Author

Should be working properly now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants