Append(CPPDEFINES=string) might concat string

[bdbaddog]

This issue was originally created at: 2009-01-28 12:11:40.
This issue was reported by: jaredgrubb.
jaredgrubb said at 2009-01-28 12:11:41

It would be nice if the following were equivalent, because the first one results in something that is not intended:

env = DefaultEnvironment(CPPDEFINES = 'foo')
env.Append(CPPDEFINES='bar')
# Result: -Dfoobar

env = DefaultEnvironment(CPPDEFINES = ['foo']) # note the list
env.Append(CPPDEFINES='bar')
# Result: -Dfoo -Dbar

gregnoel said at 2009-02-04 19:54:57

Bug party triage. Yeah, we'd like this, too, as it's a continuing source of errors. Unfortunately, we don't know of a downside-free solution; the obvious approach would add logic to a very performance-critical path. Look at this again in the 2.x timeframe; the new floor of Python 2.2 should offer additional possibilities.

garyo said at 2010-08-15 15:16:08

Fixed for 2.1, in r5133.

[mwichmann]

For future prospectors: this is fixed by special-casing in Append and AppendUnique, but not for Prepend or PrependUnique.