Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC tool supports choosing specific msvc version down to minor version #3265

Closed
dmoody256 opened this issue Jan 9, 2019 · 4 comments
Closed
Assignees
Labels
enhancement MSVC Microsoft Visual C++ Support

Comments

@dmoody256
Copy link
Contributor

Newer versions of Visual Studio support installing multiple minor versions of the MSVC toolset: https://blogs.msdn.microsoft.com/vcblog/2017/11/15/side-by-side-minor-version-msvc-toolsets-in-visual-studio-2017/

The default or latest MSVC version can be found in Auxiliary\Build\Microsoft.VCToolsVersion.default.txt, and the new vcvar batch scripts allow you to pass the minor version as an option.

SCons could support this, by allowing the minor version to be set in the enivornment, something like env['MSVC_SPECIFIC_VERSION']='14.11.1673' and then passing that along to the vcvar script call.

A TODO was introduced in #3264.

@bdbaddog bdbaddog added enhancement MSVC Microsoft Visual C++ Support labels Jan 9, 2019
@dmoody256 dmoody256 changed the title Improvement: Allow MSVC tool to choose specific msvc version down to minor version MSVC tool supports choosing specific msvc version down to minor version Jan 20, 2019
@bdbaddog
Copy link
Contributor

bdbaddog commented Apr 6, 2019

I'm thinking MSVC_VERSION= allowing more than just MM.mm and then would do a left string match
so 14.11 would match 14.11.1673 and 14.11., 14.11.1 would match 14.11.1. so split on '.' and then match pieces as far as the request.

That way no new variable needed. No change to existing build systems which don't need that specific.

Thoughts?

@mwichmann
Copy link
Collaborator

We can do this now, right? @jcbrill ?

@jcbrill
Copy link
Contributor

jcbrill commented May 16, 2022

We can do this now, right?

It is is possible to do now.

However, likely the "best" method for an end user is not implemented yet but is on the radar.

See linked comment for the gory details:
#3664 (comment)

@bdbaddog
Copy link
Contributor

Fixed In #4174

msvc bug scrub 04-2022 automation moved this from To do to Done Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement MSVC Microsoft Visual C++ Support
Projects
No open projects
Development

No branches or pull requests

4 participants