Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass Builder for StringType and FunctionType #14

Merged
merged 1 commit into from Oct 14, 2017

Conversation

bdbaddog
Copy link
Contributor

@bdbaddog bdbaddog commented Oct 14, 2017

This issue was originally created at: 2001-07-19 22:00:00.
This issue was reported by: stevenknight.
stevenknight said at 2001-07-19 22:00:00

The Builder class has explicit checks for the type of object used to build the target. It would be better OO design to do these as subclasses.

issues@scons said at 2001-07-19 22:00:00

Converted from SourceForge task item 34797

stevenknight said at 2006-05-20 20:48:48

No white space in keyword.

…ion site_scons/site_tools path prepended with every tool loaded when running with Python 3.5+.
@bdbaddog bdbaddog merged commit 351c325 into SCons:master Oct 14, 2017
@bdbaddog bdbaddog changed the title Fix issue with Tool loading logic where sys.path was getting an addition site_scons/site_tools path prepended with every tool loaded when running with Python 3.5+. Subclass Builder for StringType and FunctionType Jan 2, 2018
@bdbaddog bdbaddog added the P3 label Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant