Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed Optimization #18

Open
wurstbrot opened this issue Jun 2, 2021 · 1 comment
Open

Speed Optimization #18

wurstbrot opened this issue Jun 2, 2021 · 1 comment

Comments

@wurstbrot
Copy link
Contributor

wurstbrot commented Jun 2, 2021

Organization might use the same images with different names, e.g.:

  • registry.com/team1/mongo:3.1
  • registry.com/team2/mongo:3.1
  • registry.com/team1/mongo@sha256:123
  • registry.com/team2/mongo@sha256:123

The current algorithm doesn't take it into account. Evaluation of speed optimization should be performed.
This issue is mainly related to storage.

@philband
Copy link
Contributor

philband commented Jun 2, 2021

One possible approach would to only identify images by their manifest hash and use that as storage identified.
This would at least de-duplicate images with different tags but the same content.

For images with mismatching manifest hashes, I see no easy way. If we de-duplicate them by image name and tag, we might miss security issues present in one of the images and therefore not actually scan the images in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants