Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Proofreading to Use SwiftSyntax & SDGSwiftSource #196

Closed
SDGGiesbrecht opened this issue Nov 9, 2018 · 2 comments
Closed

Refactor Proofreading to Use SwiftSyntax & SDGSwiftSource #196

SDGGiesbrecht opened this issue Nov 9, 2018 · 2 comments
Labels
🇬🇧🇺🇸🇨🇦EN English Enhancement A request for a new feature. Merged Implemented in the master branch, but not released yet.

Comments

@SDGGiesbrecht
Copy link
Owner

Proofreading will be much faster and smarter if it uses the syntax structure instead of search patterns.

Rules will largely rely on the SyntaxScanner in the SDGSwiftSource library of SDGSwift and make good use of the textFreedom property.
@SDGGiesbrecht SDGGiesbrecht added 🇬🇧🇺🇸🇨🇦EN English Enhancement A request for a new feature. Designed Design finalized, but not yet implemented. labels Nov 9, 2018
@SDGGiesbrecht SDGGiesbrecht mentioned this issue Nov 9, 2018
Closed
@SDGGiesbrecht SDGGiesbrecht mentioned this issue Dec 18, 2018
Merged
@SDGGiesbrecht SDGGiesbrecht added Implemented Implemented in a pull request, but not yet merged into the master branch. Enhancement A request for a new feature. Merged Implemented in the master branch, but not released yet. and removed Enhancement A request for a new feature. Designed Design finalized, but not yet implemented. Implemented Implemented in a pull request, but not yet merged into the master branch. labels Dec 18, 2018
@SDGGiesbrecht
Copy link
Owner Author

SDGGiesbrecht commented Dec 20, 2018 •
edited

General refactoring released in 0.15.0.

Not all rules have switched yet.

@SDGGiesbrecht
Copy link
Owner Author

#240 will be merged shortly, which switches over the last rule.

It will be included in the 0.16.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🇬🇧🇺🇸🇨🇦EN English Enhancement A request for a new feature. Merged Implemented in the master branch, but not released yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SDGGiesbrecht