The code from SDWebImageDownloaderOperation connection:didFailWithErr…

…or: should match the code from connectionDidFinishLoading:. This fixes #872
SDWebImage · Nov 2, 2014 · 7f39e5e · 7f39e5e
1 parent 936f47c
commit 7f39e5e
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/SDWebImage/SDWebImageDownloaderOperation.m b/SDWebImage/SDWebImageDownloaderOperation.m
@@ -337,8 +337,7 @@ - (void)connectionDidFinishLoading:(NSURLConnection *)aConnection {
         responseFromCached = NO;
     }
 
-    if (completionBlock)
-    {
+    if (completionBlock) {
         if (self.options & SDWebImageDownloaderIgnoreCachedResponse && responseFromCached) {
             completionBlock(nil, nil, nil, YES);
         }
@@ -364,13 +363,17 @@ - (void)connectionDidFinishLoading:(NSURLConnection *)aConnection {
 }
 
 - (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error {
-    CFRunLoopStop(CFRunLoopGetCurrent());
-    [[NSNotificationCenter defaultCenter] postNotificationName:SDWebImageDownloadStopNotification object:nil];
+    @synchronized(self) {
+        CFRunLoopStop(CFRunLoopGetCurrent());
+        self.thread = nil;
+        self.connection = nil;
+        [[NSNotificationCenter defaultCenter] postNotificationName:SDWebImageDownloadStopNotification object:nil];
+    }
 
     if (self.completedBlock) {
         self.completedBlock(nil, nil, error, YES);
     }
-
+    self.completionBlock = nil;
     [self done];
 }