Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDWebImage 4.0.0 #1692

Closed
bpoplauschi opened this issue Oct 7, 2016 · 12 comments
Closed

SDWebImage 4.0.0 #1692

bpoplauschi opened this issue Oct 7, 2016 · 12 comments
Assignees
Milestone

Comments

@bpoplauschi
Copy link
Member

List of tickets

Releases

List of changes

  • watchOS, OS X
  • modern ObjC (instancetype, NS_DESIGNATED_INITIALIZER, Lightweight Generics, Nullability)
  • FLAnimatedImage integration
  • unit tests coverage from 35% to 70%
  • animated WebP
  • cancel requests (via newly added SDWebImageDownloadToken)
  • created SDImageCacheConfig class
  • refactored duplicate code from all WebCache categories into a UIView WebCachecategory
  • spot changes by comparing the old architecture to the new one: d2f041b
  • 4.0.0-beta changes
  • 4.0.0-beta2 changes
  • ...

Migration guide

Swift 3.0 support

@bpoplauschi bpoplauschi added this to the 4.0.0 milestone Oct 7, 2016
@bpoplauschi
Copy link
Member Author

@mythodeia @rs @matej @lavoy @akhenakh
@rromanchuk @mallorypaine @gsempe @mattjgalloway @timkoma @harishkashyap @tscheepers @voronianski
Guys, this is a very big release, we already have a working 4.0.0-beta2. I would really appreciate any help from you on testing or indicating missing parts before we can cut a final release.
I added the people I remembered being active on pull requests or conversations. Feel free to include other people if you know they can help.

@bpoplauschi
Copy link
Member Author

@rs
Copy link
Member

rs commented Oct 8, 2016

Looks great. In the migration draft, I don’t see the differrence between the 3 and 4 case. Isn’t it confusing?

@bpoplauschi
Copy link
Member Author

@rs that section is still to be complete. I've listed all the changes and I just need the basic cases covered with examples.

@bpoplauschi
Copy link
Member Author

@rs Also, I think the short description of SDWebImage points to an older documentation:http://hackemist.com/SDWebImage/doc. We can either update that (not sure how) or change that link to http://cocoadocs.org/docsets/SDWebImage, but only you can do this.

@rs
Copy link
Member

rs commented Oct 10, 2016

Fixed.

@scottrhoyt
Copy link

Thanks for the great library, guys. It has saved me so much time over the years.

Just started a new Swift 3 project and using Carthage to install 4.0.0-beta2, I get the following build warning:

screen shot 2016-10-11 at 12 08 47 pm

Everything is working fine--but I don't utilize the animated GIF support, so I'm not sure to what degree that is affected.

@nateboxer
Copy link

I'm trying to publish to itunesconnect (for TestFlight testing) and am getting these errors:

  • This bundle is invalid. The value for key CFBundleShortVersionString '4.0.0-beta2' in the Info.plist file must be a period-separated list of at most three non-negative integers.
  • This bundle Payload/.../SDWebImage.framework is invalid. The Info.plist is missing the required key: CFBundleVersion.

@skyline75489
Copy link
Member

@nateboxer This makes sense because Apple doesn't allow any "beta" software uploaded.

@bpoplauschi
Copy link
Member Author

All right guys, fingers crossed. I pushed the official 4.0.0 version.

@ivedeneev
Copy link

@bpoplauschi still getting error with "The Info.plist is missing the required key: CFBundleVersion.". any solutions?

@mythodeia
Copy link
Contributor

@ivedeneev check this

@rs rs unassigned akhenakh Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants