Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash SDWebImageDownloaderOperation.m line 247 #3433

Closed
3 tasks done
guidev opened this issue Nov 9, 2022 · 8 comments · Fixed by #3434 or #3439
Closed
3 tasks done

Crash SDWebImageDownloaderOperation.m line 247 #3433

guidev opened this issue Nov 9, 2022 · 8 comments · Fixed by #3434 or #3439
Labels
Milestone

Comments

@guidev
Copy link

guidev commented Nov 9, 2022

New Issue Checklist

Issue Info

Info Value
Platform Name ios
Platform Version 16.0
SDWebImage Version 5.14.0
Integration Method spm
Xcode Version Xcode
Repro rate sometimes (2%)
Repro with our demo prj not tested
Demo project link n/a

Issue Description and Steps

Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

I'm seeing lots of crashes on Firebase since updating to v 5.14.0

Screenshot 2022-11-09 at 15 44 17

@dreampiggy
Copy link
Contributor

Maybe related to the refactory to #3423, thread safe issue ?

@dreampiggy dreampiggy added this to the 5.14.1 milestone Nov 10, 2022
@dreampiggy
Copy link
Contributor

Someone told me that NSOperation.underlyingQueue is nil, will cause runtime crash.

img_v2_5555cf33-5064-4067-ad84-8437a70323ag

@guidev
Copy link
Author

guidev commented Nov 10, 2022

Screenshot 2022-11-10 at 17 28 47

I haven't checked if #3434 fixes this issue, but my app is available only for > iOS 14, so I don't think that's the issue

@guidev
Copy link
Author

guidev commented Nov 10, 2022

Screenshot 2022-11-10 at 17 40 04

This is from Xcode crash reports

@dreampiggy
Copy link
Contributor

These new screenshot seems another issue

@dreampiggy
Copy link
Contributor

@guidev These two crash should be fixed in 5.14.1

@guidev
Copy link
Author

guidev commented Nov 11, 2022

@dreampiggy awesome, thanks!

@JadianZheng
Copy link

JadianZheng commented Nov 12, 2022

It was luck to found this. Meet this issue when build the iOS project after upgrade macOS to 13.0.1 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants