Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Cache doesn't work on arm64 devices #668

Closed
T-Pham opened this issue Mar 18, 2014 · 5 comments
Closed

Image Cache doesn't work on arm64 devices #668

T-Pham opened this issue Mar 18, 2014 · 5 comments
Milestone

Comments

@T-Pham
Copy link
Contributor

T-Pham commented Mar 18, 2014

I see that images are still being loaded from the server each time I re-run the app. This happens on arm64 devices only.

--- Update:
I'm using version 3.5.4.

@vaiden
Copy link

vaiden commented Mar 18, 2014

Are you building a slim binary (i386 only)?

@T-Pham
Copy link
Contributor Author

T-Pham commented Mar 19, 2014

Thanks for your response!
I downloaded the framework zip file from the download page and included the framework into my project. Then either I run it on a 64-bit simulator or archive the project to IPA and run it on a 64-bit real device, the issue will happen. It doesn't happen on 32-bit devices and 32-bit simulators.
My project is configurated to support all architectures including armv7, armv7s, arm64.
Is there any log file or something I should upload here to provide more info?

@vaiden
Copy link

vaiden commented Mar 19, 2014

This is strange since SDWebImage is crashing arm64 devices running fat binaries ( = where one of the target architectures is arm64). The dreaded "unrecognized selector" crash: #494.

So you've done something that enables your app not to crash, which might be related to the fact that you can't get the caching working...

@T-Pham
Copy link
Contributor Author

T-Pham commented Mar 22, 2014

I just notice that there was a warning saying the framework was ignored since no support for arm64 architecture was found.

However, I've been able to fix this issue by cloning the code from master and build the framework myself. The newly built framework is included in a fat binary app file and works well on both 32-bit and 64-bit devices then.

@bpoplauschi
Copy link
Member

Please don't use the .framework. Install SDWebImage using CocoaPods or by using git clone --recursive

@bpoplauschi bpoplauschi added this to the Future milestone Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants