The operation will not be release after completed.

[Whirlwind]

The operation be added to AssociatedObject, and be removed when cancel or set image url.

But it will NOT be removed from AssociatedObject after completed.

Is it right?

[bpoplauschi]

I don't think we need to, since the operation is going to be deallocated. @rs am I right?

[Whirlwind]

I don't think so. The operation is be retained with OBJC_ASSOCIATION_RETAIN_NONATOMIC.

[bpoplauschi]

You are right. The operation is retained and stored using OBJC_ASSOCIATION_RETAIN_NONATOMIC. The reason why we didn't see leaks here is:

• when trying to set a new image from url, we first call cancelCurrentImageLoad that will set the old operation to nil.

[bpoplauschi]

@rs do you think we should set the operation to nil after the completion block is called aka when the operation is finished?

[rs]

Yes

[bpoplauschi]

@Whirlwind could you make a pull request with this fix? You are more familiar with this code, after your changes in #771

[bpoplauschi]

Actually, #771 removes the storage of operation, so this no longer applies.