Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing netcdf4 library #435

Closed
rogersamso opened this issue Jan 18, 2024 · 5 comments · Fixed by #437
Closed

Missing netcdf4 library #435

rogersamso opened this issue Jan 18, 2024 · 5 comments · Fixed by #437

Comments

@rogersamso
Copy link
Contributor

The netcdf4 library is required to serialize external objects to netcdf files with the serialize_external_objects method from the Macro class.

@enekomartinmartinez
Copy link
Collaborator

Hi @rogersamso

netcdf4 library is in the optional dependencies list. I would keep it there so as not to increment the dependencies as most people may not use features that need it (serialize_external_objects and dataset output). I will, in any case, include in the documentation that this function requires netcdf4 library installation.

@rogersamso
Copy link
Contributor Author

maybe a try except around the ds.to_netcdf would also be helpful, as the error message that it sends is not clear at all.

@enekomartinmartinez
Copy link
Collaborator

Yes, that will be nice. Could you take care of it, please?

@enekomartinmartinez
Copy link
Collaborator

I added info about the requirement in the installation.rst and functions docstring in the PR that will be merged tomorrow. Please let me know if you want to include the error message.

@rogersamso
Copy link
Contributor Author

I think it would be useful, but I don't have the time. So do what you think is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants