Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup tests #97

Closed
3 tasks done
j-chad opened this issue Mar 24, 2022 · 0 comments · Fixed by #103
Closed
3 tasks done

cleanup tests #97

j-chad opened this issue Mar 24, 2022 · 0 comments · Fixed by #103
Assignees
@j-chad @fishmonger45
Labels
bug Something isn't working enhancement New feature or request
Projects
Team 4 - Assignment 2 - Backend

Comments

@j-chad
Copy link
Contributor

j-chad commented Mar 24, 2022

Is your feature request related to a problem? Please describe.
The tests as they stand are not ideal. They rely on having an active connection to a database and do not have good test coverage, missing many bugs.

Describe the solution you'd like
We should take some time to refactor the tests and re-write some more thoughtful tests.

Additional context
In issue #90 an in-memory database was added which can be used for tests. Use the top of the authorisation tests for example usage (the test file wasn't fully refactored as we needed to get ts support merged).

Checklist:

  • I have double-checked that the issue does not currently exist.
  • I have added the appropriate labels (e.g. bug, enhancement, new feature).
  • I have added the Team 4 project
@j-chad j-chad added bug Something isn't working enhancement New feature or request labels Mar 24, 2022
@j-chad j-chad added this to Unscheduled in Team 4 - Assignment 2 - Backend via automation Mar 24, 2022
@j-chad j-chad moved this from Unscheduled to Ready for Development in Team 4 - Assignment 2 - Backend Mar 24, 2022
@fishmonger45 fishmonger45 moved this from Ready for Development to In progress in Team 4 - Assignment 2 - Backend Mar 28, 2022
@fishmonger45 fishmonger45 mentioned this issue Mar 28, 2022
Merged
14 tasks
Team 4 - Assignment 2 - Backend automation moved this from In progress to Done Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-chad j-chad

@fishmonger45 fishmonger45

Labels
bug Something isn't working enhancement New feature or request
Projects
Team 4 - Assignment 2 - Backend
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve test suite
2 participants
@j-chad @fishmonger45