Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#133] Fix typo in LandingView.jsx #134

Merged
merged 1 commit into from Mar 20, 2022

Conversation

hmit106
Copy link
Contributor

@hmit106 hmit106 commented Mar 19, 2022

Description:

Adds an apostrophe in the correct spot on the landing page.

Also applies latest ESLint formatting to LandingView.jsx

Closes #133

All Submissions:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project
  • My code has been commented
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@hmit106
Copy link
Contributor Author

hmit106 commented Mar 19, 2022

No idea why the diff thinks I've changed the whole file rather than just the text in the div, I'll see if I can fix

Edit - it's because this file never had ESLint applied to it after the indent size was changed :|

Copy link
Contributor

@harristomyx harristomyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@seanhogunkim
Copy link
Contributor

Copy link
Contributor

@seanhogunkim seanhogunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, maybe we should do a global lint regarding your comment about the indents? Or if it's not a big deal we can just ignore it, since people should easily be able to deal with it case by case

@harristomyx
Copy link
Contributor

Yea this will be one of the very last issues to do, so that the global lint refactor doesn't affect other open PR's before we handover the project

@hmit106 hmit106 merged commit c1218ff into SE701Team2:main Mar 20, 2022
harristomyx pushed a commit to hmit106/Updog that referenced this pull request Mar 20, 2022
MarkGuo2000 pushed a commit to MarkGuo2000/Updog that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo on landing page
3 participants