Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#161] Refactor PostCard and add activity status for posts on user profile #214

Merged
merged 4 commits into from Mar 30, 2022

Conversation

dlee432
Copy link
Collaborator

@dlee432 dlee432 commented Mar 30, 2022

Description:

Fixes #161 .
Changed the post card to match the design of the one on Figma

701 a2 1

Also added activity statuses for posts on the user profile.

701 a2 2

All Submissions:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project
  • My code has been commented
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@dlee432
Copy link
Collaborator Author

dlee432 commented Mar 30, 2022

Any ideas on why the test is failing?

@yuliapechorina
Copy link
Collaborator

Any ideas on why the test is failing?

It seems that the test is flaky. It's not immediately obvious to me as to why, but I'll look into this and fix this tomorrow. For now just re-trigger the build if it fails.

@scorpionknifes
Copy link
Collaborator

oh, it trying to run lint on ur main branch, but u renamed it

@scorpionknifes scorpionknifes changed the title Refactor PostCard and add activity status for posts on user profile [#161] Refactor PostCard and add activity status for posts on user profile Mar 30, 2022
Copy link
Collaborator

@scorpionknifes scorpionknifes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@dlee432 dlee432 merged commit 9a10b3b into SE701Team2:main Mar 30, 2022
dogeliness pushed a commit to dogeliness/Updog that referenced this pull request Apr 2, 2022
…on user profile (SE701Team2#214)

* Refactor PostCard and adding activity status for each post on user profile

* Refactor PostCard and adding activity status for posts on user profile

* Refactor PostCard and adding activity status for posts on user profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Post card component and add status at top of card component
3 participants