Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perMessageDeflate - enabling #13

Closed
SEAPUNK opened this issue Dec 3, 2015 · 3 comments
Closed

perMessageDeflate - enabling #13

SEAPUNK opened this issue Dec 3, 2015 · 3 comments

Comments

@SEAPUNK
Copy link
Owner

SEAPUNK commented Dec 3, 2015

I want to enable socket compression, but it's currently unstable. When I was running the tests, a lot of errors occurred when I was sending a lot of data back and forth, all of the errors being related to zlib.

I also want to know if compression can be a security risk: if it is, then I'll have it be off by default.
@SEAPUNK
Copy link
Owner Author

SEAPUNK commented Dec 14, 2015

Related: websockets/ws#628

@SEAPUNK
Copy link
Owner Author

SEAPUNK commented Feb 17, 2016

I think I'll let it be a configurable value that is false by default. TODO.

@SEAPUNK SEAPUNK mentioned this issue Feb 18, 2016
Merged
11 tasks
@SEAPUNK
Copy link
Owner Author

SEAPUNK commented Feb 24, 2016

Added in da8af9b

@SEAPUNK SEAPUNK closed this as completed Feb 24, 2016
@SEAPUNK SEAPUNK mentioned this issue Apr 14, 2016
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SEAPUNK