Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookings can surpass the capacity of the offering #243

Open
IElgohary opened this issue May 1, 2017 · 3 comments
Open

Bookings can surpass the capacity of the offering #243

IElgohary opened this issue May 1, 2017 · 3 comments

Comments

@IElgohary
Copy link

1. Severity:
Medium
2. Reported by:
Islam Elgohary
3. Description:
an offering can have more bookings than specified in the capacity.
a Client can create an offering and pay for it even if the capacity is full (with confirmed bookings)
a business can confirm more bookings than the offering can take.

4. Steps to reproduce the issue:

  1. as a business create a service and an offering with capacity 1
  2. as a client (client A), book the offering
  3. as a business confirm the booking of client A
  4. as another client (client B) book the same offering
  5. the offering is booked and paid for without any error
  6. as a business, you can confirm the new offering too.

5. Expected result:
The client shouldn't be able to make a booking that would result in making the number of bookings greater than the capacity of the offering.
The business shouldn't be able to confirm a booking which if confirmed, would make the number of bookings more than the capacity

@Medo3G
Copy link
Collaborator

Medo3G commented May 1, 2017

More of a missing feature than a bug. This feature was planned to be implemented but was scrapped due to time constraints. This behaviour doesn't exist, so nothing is broken.

@melzareix melzareix changed the title bookings can surpass the capacity of the offering Bookings can surpass the capacity of the offering May 1, 2017
@IElgohary
Copy link
Author

IElgohary commented May 1, 2017

since you have a capacity for the offering you must not accept more bookings than the capacity

@IElgohary
Copy link
Author

I believe that this is a serious bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants