Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The class Identifier - inconsistency between the definition and the property list, and between 8.9 and Annex A #334

Open
jimjyang opened this issue Jan 31, 2024 · 1 comment
Labels
release:3.0.0 https://semiceu.github.io/DCAT-AP/releases/3.0.0 status:fixed This issue has been fixed in a draft.

Comments

@jimjyang
Copy link

The definition of the class Identifier says "An identifier in a particular context, consisting of the string that is the identifier; an optional identifier for the identifier scheme; an optional identifier for the version of the identifier scheme; an optional identifier for the agency that manages the identifier scheme."

  1. The definition indicates that this class has one mandatory and three optional properties, while the specification has only one property, notation (skos:notation).
  2. In Annex A "Quick Reference of Classes and Properties" the property adms:identifier is Mandatory, but it is not listed/specified in 8.9.
  3. The definition of the property skos:notation (not adms:identifier) in 8.9 indicates that this is the identifier (although the human-readable name is "notation"), however, the cardinality is 0..1 (not 1..1 if this is the identifier, conf. the definition of the class).

In other words, there is inconsistency between the definition and the property specifications, and between 8.9 and Annex A.

@bertvannuffelen bertvannuffelen added release:3.0.0 https://semiceu.github.io/DCAT-AP/releases/3.0.0 status:fixed This issue has been fixed in a draft. labels Feb 1, 2024
@bertvannuffelen
Copy link
Contributor

@jimjyang thanks for pointing this out:

I rechecked DCAT-AP 2.1.1:

  • skos:notation as property is mandatory and should thus have mincard 1. That is a mistake and has been corrected.
  • The definition as it is now is indeed is prescribing a structure. In order to align with the latest release of adms I adopted the definition and usagenote of the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:3.0.0 https://semiceu.github.io/DCAT-AP/releases/3.0.0 status:fixed This issue has been fixed in a draft.
Projects
None yet
Development

No branches or pull requests

2 participants