Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load simulation parameters from a separate file #11

Open
Kastakin opened this issue Oct 22, 2019 · 4 comments · May be fixed by #30
Open

Load simulation parameters from a separate file #11

Kastakin opened this issue Oct 22, 2019 · 4 comments · May be fixed by #30

Comments

@Kastakin
Copy link

It might be a good idea to add the possibility to run SENPAI with simulation parameters loaded from an external file.
This would for example ease running the same simulation on multiple files in sequence with same parameters without having to re-type them every time or the opposite: run more simulations one after the other while just changing the conditions.
Also it's quite the standard when working with cluster computers to have the simulation parameters and the substrate on which to run it in two distinct files.

@Chelsea486MHz
Copy link
Member

Not only is it a good idea, I've had a web interface in mind for a while. Getting rid of shell flags to run simulations would pave the way for such an interface.

I'll be focusing on cleaning up the code and offloading the vector algebra to OpenCL - if you want to have a go at this two-file system, I'll be waiting for the PR :)

@Kastakin
Copy link
Author

I'm not sure on what file format to use to pass the arguments, I was thinking of a JSON file but I'm not sure if it's the standard for similar applications

@Chelsea486MHz
Copy link
Member

Back when the project was in its infancy, it was planned to use JSON. I don't know if it's "the norm" but it sure keeps it simple.

AFAIK, "the norm" is to use PDB files instead of MOL ones anyway, so using JSON parameters doesn't seem outrageous in this context.

@Luthaf
Copy link

Luthaf commented Nov 8, 2019

"the norm" is to use PDB files instead of MOL ones anyway, so using JSON parameters doesn't seem outrageous in this context.

"big" simulation software have their own file format: GROMACS uses .top/.gro files, LAMMPS uses another format, and don't get me started on ab initio molecular dynamics software 😃

Whatever you choose to do, please don't add a new format to this zoo =) JSON/YAML/TOML sounds very nice for model/force-field parameters. You may want to use a format able to store velocities for your initial structures, to remove the need for initial thermostating in NVT simulations.

There are two projects I know about concerning the standardization of models input: https://openforcefield.org/ and https://openkim.org/. I don't know how widely they are used in the community.

@Chelsea486MHz Chelsea486MHz linked a pull request Jul 21, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants