Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there's a compilation error in a meta test, inform the teacher #227

Open
mauricioaniche opened this issue Jun 29, 2023 · 2 comments · May be fixed by #260
Open

If there's a compilation error in a meta test, inform the teacher #227

mauricioaniche opened this issue Jun 29, 2023 · 2 comments · May be fixed by #260
Assignees
Labels
enhancement New feature or request Medium priority

Comments

@mauricioaniche
Copy link
Contributor

mauricioaniche commented Jun 29, 2023

Right now, if there's a compilation error due to a badly written meta test, Andy just considers that meta test to fail. That's not correct. If the meta test makes the code to not compile, we should alert the teacher right away.

If during EXAM mode (hopefully never), just show a message. In any other mode, paste the entire meta test + compilation error, so it gets easier to identify the problem.

Changes most likely should happen here: https://github.com/SERG-Delft/andy/blob/main/andy/src/main/java/nl/tudelft/cse1110/andy/execution/metatest/library/LibraryMetaTest.java

@mauricioaniche mauricioaniche added enhancement New feature or request Medium priority labels Jul 2, 2023
@AtillaColak
Copy link
Contributor

Can I work on this as well?

@martinmladenov
Copy link
Collaborator

I just assigned to the issue. Thanks! Let us know if you have any questions.

@AtillaColak AtillaColak linked a pull request Aug 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants