Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception Handling #24

Closed
avandeursen opened this issue Apr 18, 2014 · 1 comment · Fixed by #28
Closed

Exception Handling #24

avandeursen opened this issue Apr 18, 2014 · 1 comment · Fixed by #28

Comments

@avandeursen
Copy link
Member

Currently, incorrect configuration can throw IOException and IllegalArgumentException, which in some cases are wrapped into RuntimeException.

My proposal is to introduce one top level checked PacmanConfigurationException, which can replace/wrap the existing exceptions.

/cc @rsouzacoelho

@michaeldejong
Copy link
Contributor

A PacmanConfigurationException class sounds nice. 👍 But I'm not so sure about making it checked. It sounds like it's an Exception from which you cannot recover, in which case you're just littering your code.

Also see "The Java Programming Language (page 60)

Unchecked exceptions represent conditions that, generally speaking, reflect errors in your program's logic and cannot be reasonably recovered from at run time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants