Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search function minor improvement #27

Closed
LorenzoRinaldi opened this issue Apr 11, 2022 · 1 comment
Closed

search function minor improvement #27

LorenzoRinaldi opened this issue Apr 11, 2022 · 1 comment

Comments

@LorenzoRinaldi
Copy link
Collaborator

The search function should not be case sensitive. For instance, if the user run this command:

db.search("Sector","electricity")

he will not be able to track for sectors named "Electricity..." with capital "E".
It would be super-useful to improve this making the function not case-sensitive
mohammadamint added a commit that referenced this issue Apr 18, 2022
@mohammadamint
Improving search function in CoreModel(issue #27)
cd9e179 
- Adding a new argument to the function : "ignore_case"
- if the ignore_case = True, re.complie function will take re.IGNORECASE
  flag which ignores sensitivity on letter cases for search
- if the ignore_case = False, it will remain sensitivity to cases.
@mohammadamint
Copy link
Collaborator

fixed by commit : cd9e179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LorenzoRinaldi @mohammadamint