Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-paste ImGui_ImplOpenGL2_RenderDrawData from ImGui's example #79

Closed
eliasdaler opened this issue May 13, 2019 · 4 comments
Closed

Comments

@eliasdaler
Copy link
Contributor

Looks like it does almost everything that we need and properly sets up/restores states.
Maybe this will allow us to not use resetGLStates anymore?

Here's one problems, though - it doesn't support OpenGL ES. @Alia5 - can you take a look at it and maybe even add ES support via PR to ImGui directly?

@eliasdaler
Copy link
Contributor Author

eliasdaler commented May 15, 2019

I think I'll also attempt to get this function from ImGui's examples folder, and while it might seem shady, the example's implementation is more flexible and are better maintained.

Though it might make build a bit harder for people not using CMake (will need to include one more .cpp file into build)

@eliasdaler
Copy link
Contributor Author

See this branch where this is now done: https://github.com/eliasdaler/imgui-sfml/tree/opengl-sync
Please test it, but it looks good for me.

@eliasdaler
Copy link
Contributor Author

Looks like with some work it's possible to use this impl directly, but I'm not sure if it'll work on OpenGL ES since the current ImGui-SFML implementation has some #ifdefs in rendering code related to it.

@eliasdaler
Copy link
Contributor Author

Did this in 224fe6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant