Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons on people page should have either ARIA labels or be restructured #237

Open
Inkering opened this issue Jun 18, 2020 · 0 comments
Open

Comments

@Inkering
Copy link
Contributor

part of a series of accessibility improvements//maintenance taeyoon asked me to work on, I'm going to sort through and make PR's for these where possible

On the grid-based people page, each link section for each person could benefit a text label describing the role of the link icon beyond the url.

</span><span class="links">
{% if person.twitter %}
<a href="http://twitter.com/{{ person.twitter }}"><i class="fa fa-twitter"></i></a>
{% endif %}
{% if person.github %}
<a href="http://github.com/{{ person.github }}"><i class="fa fa-github"></i></a>
{% endif %}
{% if person.instagram %}
<a href="http://instagram.com/{{ person.instagram }}"><i class="fa fa-instagram"></i></a>
{% endif %}
{% if person.website %}
<a href="{{ person.website }}"><i class="fa fa-globe"></i></a>
{% endif %}
{% if person.email %}
<a href="mailto:{{ person.email }}"><i class="fa fa-email"></i></a>
{% endif %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant