Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate code in misc and pde module #140

Closed
leiterrl opened this issue Jul 30, 2019 · 1 comment · Fixed by #214
Closed

Duplicate code in misc and pde module #140

leiterrl opened this issue Jul 30, 2019 · 1 comment · Fixed by #214
Labels
bug Crashes, freezes, compilation/run-time errors, undesirable behavior, wrong info in help/docs confirmed Issues that have been reproduced by another user (not the submitter)

Comments

@leiterrl
Copy link
Member

It seems that the following files are completely identical:

misc/src/sgpp/misc/pde/algorithm/UpDownOneOpDimEnhanced.cpp
pde/src/sgpp/pde/algorithm/UpDownOneOpDimEnhanced.cpp

maybe this was just left over when moving stuff out of the misc module
@valentjn
Copy link
Member

valentjn commented Aug 3, 2019

Yes, I think in 58bb9f8 we copied the misc file to pde, but we forgot to delete the misc one.

@valentjn valentjn added bug Crashes, freezes, compilation/run-time errors, undesirable behavior, wrong info in help/docs confirmed Issues that have been reproduced by another user (not the submitter) labels Aug 3, 2019
@leiterrl leiterrl mentioned this issue Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Crashes, freezes, compilation/run-time errors, undesirable behavior, wrong info in help/docs confirmed Issues that have been reproduced by another user (not the submitter)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove duplicate code (UpDownOneOpDimEnhanced) in misc SGpp/SGpp
2 participants
@valentjn @leiterrl