Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natten 0.14.5 (CPU) issue regarding natten2dqkrpb #23

Closed
ydshieh opened this issue Mar 17, 2023 · 4 comments
Closed

natten 0.14.5 (CPU) issue regarding natten2dqkrpb #23

ydshieh opened this issue Mar 17, 2023 · 4 comments

Comments

@ydshieh
Copy link

ydshieh commented Mar 17, 2023

Dear NATTEN author(s)/team:

Since 0.14.5, our CI (transformers) encounters a problem with natten2dqkrpb, which mentions missing 1 required positional argument: 'dilation'. With 0.14.4, there is no such problem.

I can try to provide a (short) code snippet (without using the testing code in transformers), but I am wondering if there is a breaking change introduced in natten==0.14.5. Thank you :-)

Here is the error message we got

        # Compute NA between "query" and "key" to get the raw attention scores, and add relative positional biases.
>       attention_scores = natten2dqkrpb(query_layer, key_layer, self.rpb, 1)
E       TypeError: natten2dqkrpb() missing 1 required positional argument: 'dilation'
@alihassanijr
Copy link
Member

Hello,

It's because the new build makes RPB optional. I'd have to start a pull request to transformers to resolve that.

@ydshieh
Copy link
Author

ydshieh commented Mar 17, 2023

Thank you a lot, @alihassanijr ❤️

@alihassanijr
Copy link
Member

Started PR:

huggingface/transformers#22229

@alihassanijr
Copy link
Member

Closing this since I believe the PR solved the issue.
Feel free to open it back up if that is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants